Fix 4 parser tests with EXPLAIN AST improvements #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix EXTRACT function mapping to use ClickHouse's exact function names (e.g., toDayOfMonth instead of toDay for EXTRACT(DAY FROM ...)) - Fix UseQuery explain format to output UseQuery with children count and Identifier child - Add ExistsTableQuery explain handler for EXISTS TABLE/DATABASE/DICTIONARY - Fix ShowTables FROM database to include database identifier as child Tests enabled: - 00619_extract - 00950_dict_get - 01048_exists_query - 01161_information_schema
Add special handling for ShowCreateDatabaseQuery in explainShowQuery to produce the expected output format with database identifier.
OrderByElement now outputs the COLLATE clause as a child Literal when a collation is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g., toDayOfMonth instead of toDay for EXTRACT(DAY FROM ...))
and Identifier child
Tests enabled: