-
Notifications
You must be signed in to change notification settings - Fork 978
Include column types for composite type #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Intentionally left endtoend test failing, until I verify that generated code does work as intended |
|
Tested this, breaks if a column is an array of composite type. Otherwise works fine, except that |
|
any update? will it get merged it? |
|
Doesn't look like anyone had a chance to review this PR, and I haven't reached out to anyone to speed this up. I'm surprised that it still doesn't have any conflicts, so I don't mind making small adjustments to get this merged if needed. |
|
I've been using a slightly modified version of this for a couple of months now. Overall, it's a really great improvement that I hope to see merged upstream soon. I have noticed a few things that would help improve it:
|
With this addition, it should be possible to implement codegen on pgx/v5 side to resolve #2760
. Not sure for other drivers.
I intend to implement codegen as part of this PR as well, just want to get visibility as soon as possible.