fix: escape constant names in queries #3961
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
dosubot
bot
added
size:L
Author
|
Interesting, it looks like the generated names for constants are not escaped |
Also adds `any` as a reserved keyword, as it was introduced in Go 1.18. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Author
|
@kyleconroy I just realised this might be noisier than needed, since the linter ignores generated files. Would you want me to split the bug fix out into a separate PR and close this? |
Author
|
@kyleconroy gentle ping, this fixes an actual bug, I've renamed the PR to better reflect that :) |
snprajwal
changed the title
any in place of interface{}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant names in queries were not escaped, leading to keywords being emitted as constant names in the generated output. This has been updated to be escaped, and
anyhas been added as a reserved keyword as of Go 1.18.This also addresses the lint raised by gopls on sqlc's generated Go files for modernizing the usage of an empty interface for the
anytype.