Migrate from AppVeyor to GitHub Actions#1539
Conversation
|
Test results and artifacts: https://github.com/sshnet/SSH.NET/actions/runs/11869304328 It still tries to run AppVeyor here. I assume this must be disabled in the project. side note: I have not seen a single flaky test failure while testing this. 😄 |
this is needed to re-run jobs manually from the web UI
Rob-Hague
left a comment
There was a problem hiding this comment.
A lot faster too. One thing I think is missing at the moment is a CI nuget feed that we get automatically with appveyor.
Unless you want to take a look now, I suggest we just keep only the dotnet pack part of appveyor.yml to keep that bit going, and then look to use github packages or similar for a CI feed in a follow-up
(also because I don't think I have permissions to remove the appveyor check so easiest to keep around in the meantime)
only on develop branch.
so it doesn't fail CI until AppVeyor integration is disabled
|
I was actually already looking into pushing to the GitHub NuGet Registry. I just finished it up and pushed it here. NuGet result can be seen here: https://github.com/mus65/SSH.NET/pkgs/nuget/SSH.NET . This will not run for this PR because of the filter on the develop branch. I will add a minimal appveyor.yml to avoid failure (just tested with an empty file, but that doesn't seem to work). |
|
The NuGet package was pushed successfully on the develop branch, but it's not actually visible. I think this may be related to the Package permissions settings on the organization (which I obviously don't have access to). |
|
Should be good now |
Follow-up sshnet#1539. Looks like AppVeyor has been disabled.
Follow-up #1539. Looks like AppVeyor has been disabled.
This migrates from AppVeyor to GitHub Actions. This initially came up in #1480 (comment) because we would have to wait for AppVeyor to support .NET 9 .
I tried to keep the functionality mostly the same. I made the following changes:
-cand--no-restoreparameters from dotnet callsCoverlet results are still only archived but not integrated or displayed anywhere. There is #1257 open for this. There is also some kind of GitHub Integration for this. I could look into this separately.