Bump trino-cli version #822
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Approving this as the change LGTM. I hope you will figure the Nexus problems
| sleep 1 # it takes time before the statefulset is recreated | ||
|
|
||
| echo "Waiting for superset StatefulSet ..." | ||
| kubectl rollout status --watch statefulset/superset-node-default | ||
|
|
||
| sleep 2 # just to be sure we're up and running No newline at end of file | ||
| sleep 2 # just to be sure we're up and running |
There was a problem hiding this comment.
No need to change, but ideally we just use a kubectl wait supersetcluster/superset (pseudo code) here (same below for trino)
There was a problem hiding this comment.
I'm not so sure. I think statefulsets are a bit weird for conditional waits.
I did try to put something in that I did for deployments, but it doesn't work for statefulsets: https://github.com/stackabletech/actions/blob/c34dbb4f27b274736c7d2edc6f6f30a03d03edf5/run-integration-test/action.yaml#L216-L218
There was a problem hiding this comment.
I was thinking of something like kubectl wait --for=condition=available trinocluster/trino --timeout 1200s, can you give that a try?
For Superset that would be kubectl wait --for=condition=available supersetcluster/superset --timeout 1200s
There was a problem hiding this comment.
You try it and tell me :D
I don't have my cluster anymore.
There was a problem hiding this comment.
I guess not super important 😅
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Part of stackabletech/docker-images#1383
I fixed the example to use the correct trino-cli file, and fix old usages of
stackablectl svc.