Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Jan 13, 2026

Description

Fixes #534

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 marked this pull request as ready for review January 16, 2026 13:52
@adwk67 adwk67 self-assigned this Jan 16, 2026
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Jan 16, 2026
@dervoeti dervoeti self-requested a review January 18, 2026 15:16
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 19, 2026
@adwk67
Copy link
Member Author

adwk67 commented Jan 19, 2026

Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a few nits.

Also: As far as I see it the integration test currently does not validate whether an action is denied by OPA, only that sending/receiving messages succeed. Maybe we should test some action that would be denied? Because currently, at least in theory, the test would also succeed if the OPA config is ignored for some reason and all actions are allowed by default.

@adwk67
Copy link
Member Author

adwk67 commented Jan 19, 2026

I've extended the test to filter on topic names so that we can also test that there is no access to a disallowed topic:

--- PASS: kuttl (111.42s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-false_openshift-false_krb5-1.21.1 (101.45s)
        --- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-true_openshift-false_krb5-1.21.1 (110.51s)
PASS

Co-authored-by: Lukas Krug <lukas.krug@stackable.tech>
@adwk67 adwk67 added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit 7d70202 Jan 19, 2026
12 checks passed
@adwk67 adwk67 deleted the feat/opa-with-tls branch January 19, 2026 15:55
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jan 19, 2026
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jan 19, 2026
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

feat: Add opa-tls functionality/opa integration test

4 participants