-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add OPA TLS integration and test #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dervoeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a few nits.
Also: As far as I see it the integration test currently does not validate whether an action is denied by OPA, only that sending/receiving messages succeed. Maybe we should test some action that would be denied? Because currently, at least in theory, the test would also succeed if the OPA config is ignored for some reason and all actions are allowed by default.
|
I've extended the test to filter on topic names so that we can also test that there is no access to a disallowed topic: --- PASS: kuttl (111.42s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-false_openshift-false_krb5-1.21.1 (101.45s)
--- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-true_openshift-false_krb5-1.21.1 (110.51s)
PASS |
Co-authored-by: Lukas Krug <lukas.krug@stackable.tech>
Description
Fixes #534
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker