Grafana: Add more link speed mappings to node exporter dashboard #2047
Conversation
Also, display just the physical link speeds + bonds for combined speed of individual links.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the Node Exporter dashboard by adding mappings for higher link speeds (25G, 50G, 100G, 200G) and refining the 'Link Speed' panel to display only physical and bonded interfaces. The changes are a good improvement. I have one suggestion to make the interface filter more comprehensive.
| "editorMode": "code", | ||
| "exemplar": false, | ||
| "expr": "max by (device)(node_network_speed_bytes{instance=\"$node\",job=\"$job\", device!~\"tap.*\"})", | ||
| "expr": "max by (device)(node_network_speed_bytes{instance=\"$node\",job=\"$job\", device=~\"(en.*|eth.*|bond.*)\"})", |
There was a problem hiding this comment.
The new regex (en.*|eth.*|bond.*) is a great improvement for filtering physical and bonded interfaces. However, it might be beneficial to also include InfiniBand interfaces, which are common in high-performance environments and can have speeds like the ones you've added (e.g., 100G, 200G). InfiniBand interfaces are typically named with an ib prefix (e.g., ib0).
Consider adding ib.* to the regex to include these interfaces.
"expr": "max by (device)(node_network_speed_bytes{instance=\"$node\",job=\"$job\", device=~\"(en.*|eth.*|bond.*|ib.*)\"})"
Also, display only physical link speeds + bonds for combined speed of individual links.