STACKITSBM-463 - update docs - rrule,maintenance_window#1221
Open
aeter wants to merge 1 commit intostackitcloud:mainfrom
Open
STACKITSBM-463 - update docs - rrule,maintenance_window#1221aeter wants to merge 1 commit intostackitcloud:mainfrom
aeter wants to merge 1 commit intostackitcloud:mainfrom
Conversation
New `rrule` and `maintenance_window` docstrings for serverbackup and serverupdate schedules. ref STACKITSBM-463 --- Tests: ``` [~/terraform-provider-stackit] make project-tools [~/terraform-provider-stackit] make generate-docs ... [~/terraform-provider-stackit] make fmt [~/terraform-provider-stackit] golangci-lint run --allow-parallel-runners --timeout=5m --config=./golang-ci.yaml stackit/internal/services/serverbackup/schedule/*.go [~/terraform-provider-stackit] golangci-lint run --allow-parallel-runners --timeout=5m --config=./golang-ci.yaml stackit/internal/services/serverupdate/schedule/*.go [~/terraform-provider-stackit] go test stackit/internal/services/serverbackup/schedule/* ok command-line-arguments 0.005s [~/terraform-provider-stackit] go test stackit/internal/services/serverupdate/schedule/* ok command-line-arguments 0.004s ``` Signed-off-by: Adrian Nackov <adrian.nackov@mail.schwarz>
Contributor
|
Hi @aeter, thank you for your contribution. I've added this PR to our review queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
rruleandmaintenance_windowdocstrings for serverbackup and serverupdate schedules.ref STACKITSBM-463
Tests:
Description
relates to STACKITSBM-463
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)