feat: Add Knative Service support #1058
Closed
+409
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Knative Services in Reloader, addressing Issue #493.
Problem
Previously, Reloader did not support Knative Services. When users tried to use Reloader with Knative Services, the pods would be created but then immediately terminated, leaving the old pod running. This is because directly modifying the underlying Deployment causes Knative's controller to reconcile and revert changes (see Knative Serving Issue #14705).
Solution
This implementation correctly updates the Knative Service resource itself by modifying
spec.template, which triggers Knative to create a new revision. This is the proper way to update Knative Services and avoids conflicts with Knative's reconciliation loop.Changes
spec.templateto trigger new revisions (not Deployment)Implementation Details
spec.template.metadata.annotationsfor annotations strategyspec.template.spec.containersfor env-vars strategyTesting
Usage
Knative Services work the same way as other resources. Simply add Reloader annotations:
Related Issues
Checklist