Open
Conversation
…image's resolution
…M directly. Add error handling
…ad detection, add cleanup and improve error handling
…ay. who uses gifs for anything other than animation these days?
the query string way only worked for the same request. when you come back to the page and the non-query string image loads, it'll still be old.
…opped can be initialized once the stack is ready.
…ot required this way.
… the image is already cached or needs to be loaded.
events would be removed when the croppers stack is closed, then they are attempted to be removed again on mount (when the editor is closed), at which point the image isnt there.
…ter handle access, dragmode to crop to draw new box easier
…e back if you had dragged it away.
This reverts commit aa10dc5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses cropper.js to add a new image crop feature, complete with aspect ratio and orientation flipping.
When finished cropping you can choose to save as a new image or replace the existing one.

Note
Medium Risk
Adds a new client-side image cropping and re-upload flow, including optional overwrite of existing assets, which could impact asset integrity and upload behavior if edge cases slip through. Changes also adjust stack open timing (
Stack.vue) which may affect other stack consumers’ lifecycle assumptions.Overview
Adds an image cropping feature to the asset editor using
cropperjs, including a newCropEditor.vuestack with aspect-ratio presets, orientation flipping, keyboard shortcuts, and basic CORS/error handling.Introduces a post-crop confirmation flow to either save a new copy (timestamped upload) or replace the original (overwrite upload), then redirects to the new asset or reloads the current one and busts image caches. Also tweaks
Stack.vueto emitopenedon the next tick and adds a newcroptoolbar icon.Written by Cursor Bugbot for commit 2580633. This will update automatically on new commits. Configure here.