Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| public function findById(string $id) | ||
| { | ||
| [$container_id, $path] = explode('::', $id); | ||
| $path = str_replace('\\', '/', $path); |
There was a problem hiding this comment.
Backslashes in filenames become unreachable
Low Severity
findById now unconditionally converts \ to / in the asset path. This changes the identifier semantics for assets whose real path contains a literal backslash, so an id() generated from that asset can no longer be resolved by findById.
Member
Author
There was a problem hiding this comment.
I don't think this would/could ever happen 🧐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6064
Note
Low Risk
Small, targeted change to path normalization plus a regression test; minimal behavioral impact outside Windows-style ID inputs.
Overview
Fixes asset lookup by ID when the asset path contains Windows-style
\\separators.AssetRepository::findByIdnow normalizes the extracted path by converting backslashes to/before resolving the asset, and a new test assertsfind('container::foo\\bar.jpg')correctly returns the saved asset.Written by Cursor Bugbot for commit fbc5da1. This will update automatically on new commits. Configure here.