[6.x] Adding wildcard permission support#14070
Open
martinoak wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Adding wildcard permission support#14070martinoak wants to merge 1 commit intostatamic:6.xfrom
martinoak wants to merge 1 commit intostatamic:6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #12791
Implement wildcard permission support to allow using * as a placeholder in permission strings, enabling simplified role configuration.
In nutshell, I have extended
hasPermission()function and created a newmatchesWildcard()function to use a regex and parse the wildcard entries inroles.yamlfile.What is allowed now:
roles.yaml:What led me to this change:
The current
roles.yamlfile can contain 11 times the same, repetitive setup. For example, the "editor" role lists the same permissions for 11 different collections, resulting in 99 nearly identical permission entries.Example Transformations
view * entries/^view .* entries$/view courses entriesview news entriesedit courses entriesview courses terms* * terms/^.* .* terms$/view machines termsedit regions termsview machines entriesedit other authors * entries/^edit other authors .* entries$/edit other authors courses entriesdelete other authors courses entriesTesting
I tried to write some tests for that, but I'm not sure, if its OK, havent practiced much in writing tests.