[6.x] Fix replicator preview text merging during reorder#14072
Open
dannyuk1982 wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Fix replicator preview text merging during reorder#14072dannyuk1982 wants to merge 1 commit intostatamic:6.xfrom
dannyuk1982 wants to merge 1 commit intostatamic:6.xfrom
Conversation
…uring reorder
When drag-and-drop reordering replicator sets of different types, the
collapsed preview text incorrectly merged fields from multiple set types.
This happened because stale preview entries from the old set type remained
at index-based paths, and the previewText filter failed to exclude fields
that don't belong to the current set type — when a field handle wasn't
found in the set's config, it fell back to {} and {}.replicator_preview
=== undefined evaluated to true, letting foreign fields pass through.
Now when a field handle is not found in the current set's config, it
returns false immediately, filtering out any stale foreign-type fields.
Fixes statamic#14071
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dannyuk1982
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previewTextnow returnsfalse(filters it out) instead of falling through to the defaultshowFieldPreviewsbehaviorSet.vue(replicator) andManagesPreviewText.js(shared by Bard sets & Group fieldtype)Fixes #14071
Test plan
🤖 Generated with Claude Code