Skip to content

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Jan 29, 2026

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/signrank/* packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Refactors to use string interpolation.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 29, 2026
@hrshya hrshya added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. labels Jan 29, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/signrank/cdf $\color{red}309/311$
$\color{green}+99.36%$
$\color{red}36/37$
$\color{green}+97.30%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{red}309/311$
$\color{green}+99.36%$
stats/base/dists/signrank/pdf $\color{red}358/360$
$\color{green}+99.44%$
$\color{red}36/37$
$\color{green}+97.30%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{red}358/360$
$\color{green}+99.44%$
stats/base/dists/signrank/quantile $\color{green}305/305$
$\color{green}+100.00%$
$\color{green}45/45$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}305/305$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 29, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 29, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: update random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/9976

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 221e7ef into stdlib-js:develop Jan 30, 2026
119 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 30, 2026
@hrshya hrshya deleted the bench/signrank branch January 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants