Skip to content

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Jan 30, 2026

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/weibull/* packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Refactors to use string interpolation.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 30, 2026
@hrshya hrshya added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. labels Jan 30, 2026
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 30, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/weibull/cdf $\color{green}298/298$
$\color{green}+0.00%$
$\color{green}25/25$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}298/298$
$\color{green}+0.00%$
stats/base/dists/weibull/ctor $\color{red}486/487$
$\color{green}+0.00%$
$\color{green}33/33$
$\color{green}+0.00%$
$\color{red}18/19$
$\color{green}+0.00%$
$\color{red}486/487$
$\color{green}+0.00%$
stats/base/dists/weibull/entropy $\color{green}197/197$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}197/197$
$\color{green}+0.00%$
stats/base/dists/weibull/kurtosis $\color{green}208/208$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}208/208$
$\color{green}+0.00%$
stats/base/dists/weibull/logcdf $\color{green}311/311$
$\color{green}+0.00%$
$\color{green}28/28$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}311/311$
$\color{green}+0.00%$
stats/base/dists/weibull/logpdf $\color{green}308/308$
$\color{green}+0.00%$
$\color{green}35/35$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}308/308$
$\color{green}+0.00%$
stats/base/dists/weibull/mean $\color{green}195/195$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}195/195$
$\color{green}+0.00%$
stats/base/dists/weibull/median $\color{green}197/197$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}197/197$
$\color{green}+0.00%$
stats/base/dists/weibull/mgf $\color{green}344/344$
$\color{green}+0.00%$
$\color{green}29/29$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}344/344$
$\color{green}+0.00%$
stats/base/dists/weibull/mode $\color{green}199/199$
$\color{green}+0.00%$
$\color{green}12/12$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}199/199$
$\color{green}+0.00%$
stats/base/dists/weibull/pdf $\color{green}310/310$
$\color{green}+0.00%$
$\color{green}36/36$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}310/310$
$\color{green}+0.00%$
stats/base/dists/weibull/quantile $\color{green}294/294$
$\color{green}+0.00%$
$\color{green}25/25$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}294/294$
$\color{green}+0.00%$
stats/base/dists/weibull/skewness $\color{green}210/210$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}210/210$
$\color{green}+0.00%$
stats/base/dists/weibull/stdev $\color{green}199/199$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}199/199$
$\color{green}+0.00%$
stats/base/dists/weibull/variance $\color{green}199/199$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}199/199$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants