Make contract invoke auto-convert values when type is string.#2410
Open
Make contract invoke auto-convert values when type is string.#2410
contract invoke auto-convert values when type is string.#2410Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves stellar contract invoke argument parsing by coercing non-quoted numeric inputs into String contract parameters, aligning CLI behavior with the contract function’s declared type (fixes #2334).
Changes:
- Coerce non-string JSON primitives into
Value::Stringwhen the expectedScTypeisString. - Add unit tests covering
Stringparsing from numeric, boolean, bare-word, and JSON-quoted inputs.
cb2cea5 to
fdaa853
Compare
contract invoke.contract invoke.
contract invoke.contract invoke auto-convert values when type is string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Before:
After:
Why
Fix #2334.
Known limitations
N/A