-
Notifications
You must be signed in to change notification settings - Fork 913
fix(SU2_CFD, Common): Fix physical correctness, robustness, and MDO compatibility #2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(SU2_CFD, Common): Fix physical correctness, robustness, and MDO compatibility #2669
Conversation
This commit addresses several issues in the SU2 codebase: 1. Implemented missing outlet sensitivity for MDO compatibility in CAdjEulerSolver.cpp. 2. Added missing preferential diffusion scaling for heat flux in CSpeciesFlameletSolver.cpp. 3. Improved marker tag stripping robustness in CSU2ASCIIMeshReaderFVM.cpp. 4. Added missing MPI communications to SetGridVel_Gradient in CSolver.cpp. 5. Adjusted spacing and formatting to align with SU2 style (Google based). Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
| /*--- Account for preferential diffusion in computation of the heat flux ---*/ | ||
| if (flamelet_config_options.preferential_diffusion) { | ||
| thermal_conductivity *= nodes->GetAuxVar(iPoint, FLAMELET_PREF_DIFF_SCALARS::I_BETA_ENTH_THERMAL); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show me the derivation of the CHT boundary condition from first principles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the flamelet model with preferential diffusion enabled, the total diffusive heat flux
In the Flamelet Generated Manifold (FGM) approach, species mass fractions
Specifically,
For the CHT (Conjugate Heat Transfer) boundary condition, first principles require the matching of heat fluxes at the interface:
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Proposed Changes
This PR addresses several impact-focused bug fixes and physical enhancements in the SU2 solver across the CFD and Common modules. The modifications improve MDO adjoint sensitivities, ensure physical correctness in flamelet heat flux calculations, add necessary MPI synchronization for dynamic mesh gradients, and enhance mesh reader robustness.
Key Fixes:
CAdjEulerSolver.cppfor MDO compatibility.Beta_Enth_Thermalscaling to isothermal wall heat flux inCSpeciesFlameletSolver.cppwhen preferential diffusion is enabled.InitiateCommsandCompleteCommsforGRID_VELOCITYinSetGridVel_Gradient(CSolver.cpp) for partition consistency.std::remove_iffor marker tags inCSU2ASCIIMeshReaderFVM.cpp.Related Work
CMultiGridGeometry.cppandupdateHistoryMap.pyto maintain original logic.CSolver.cpp(e.g.,ITER=9) to ensure zero overlap with recent past commits.PR Checklist
blackfor Python and manual Google-style audit for C++).walkthrough.md.