Open
Conversation
gordonbrander
commented
Sep 5, 2023
Collaborator
Author
gordonbrander
left a comment
gordonbrander
left a comment
There was a problem hiding this comment.
We should make changes to the approach.
| @MainActor var state: Model { get } | ||
|
|
||
| func send(_ action: Model.Action) -> Void | ||
| @MainActor func send(_ action: Model.Action) -> Void |
Collaborator
Author
There was a problem hiding this comment.
Rather than isolating send to main actor, we may want to allow send to be nonisolated, and have a separate main-actor isolated transact method which does the actual transaction. This would give us more flexibility in where we can call send, while ensuring state changes only happen on main.
| associatedtype Model: ModelProtocol | ||
|
|
||
| var state: Model { get } | ||
| @MainActor var state: Model { get } |
Collaborator
Author
There was a problem hiding this comment.
Get-only property should be nonisolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
This should make it impossible to update the state outside the main thread (make it impossible to trigger a purple warning).