fix: removes original entrypoint and cleans up orphaned shared memory #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original entrypoint (bootstrap-postgres-ha.sh) somehow doesn't exist anymore. This is probably due to an update in the base image that we missed. Funny enough, the postgres-operator overrides the entrypoint, so we haven't seen any failures. This patch will be accompanied by an update to postgres-operator that uses the entrypoint-wrapper if a new flag file is present (required for backwards compatibility and safe rollout): /usr/local/bin/.entrypoint-wrapper-version Additionally, we add to the postgres-oom-adjuster script shared memory cleanup when it can't find the postmaster. This is a workaround that allow us to recover from PID reuse failures caused by patroni concurrently demoting a replica. The proper fix is upgrading to Patroni >= 4.0.6. Ref.: patroni/patroni#3372 Signed-off-by: Juliana Oliveira <juliana@fly.io>
Signed-off-by: Juliana Oliveira <juliana@fly.io>
Signed-off-by: Juliana Oliveira <juliana@fly.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original entrypoint (bootstrap-postgres-ha.sh) somehow doesn't
exist anymore. This is probably due to an update in the base image that
we missed. Funny enough, the postgres-operator overrides the entrypoint,
so we haven't seen any failures.
This patch will be accompanied by an update to postgres-operator that
uses the entrypoint-wrapper if a new flag file is present (required for
backwards compatibility and safe rollout):
/usr/local/bin/.entrypoint-wrapper-version
Additionally, we add to the postgres-oom-adjuster script shared memory
cleanup when it can't find the postmaster. This is a workaround that
allow us to recover from PID reuse failures caused by patroni concurrently
demoting a replica. The proper fix is upgrading to Patroni >= 4.0.6.
Ref.: patroni/patroni#3372
Signed-off-by: Juliana Oliveira juliana@fly.io