jextract/jni: add support for optional Date and Date#568
Merged
ktoso merged 3 commits intoswiftlang:mainfrom Feb 18, 2026
Merged
jextract/jni: add support for optional Date and Date#568ktoso merged 3 commits intoswiftlang:mainfrom
Date and Date#568ktoso merged 3 commits intoswiftlang:mainfrom
Conversation
Collaborator
|
Hah, that's actually something I hit recently, thanks :-) |
ktoso
reviewed
Feb 18, 2026
| throw JavaTranslationError.unsupportedSwiftType(swiftType) | ||
| } | ||
|
|
||
| return NativeParameter( |
Collaborator
There was a problem hiding this comment.
Kinda tempted to add a debug or trace log statement here... Might be easier to spot omissions in future in with trace logging?
Contributor
Author
There was a problem hiding this comment.
Sure. I added some debug logging
ktoso
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
Optional<Date>andOptional<Data>