Skip to content

Conversation

@hirasso
Copy link
Member

@hirasso hirasso commented Jun 6, 2025

Description

Track progress of the new scroll mechanic, related enhancements and API changes here

Checks

  • The PR is submitted to the main branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

hirasso and others added 10 commits May 31, 2025 18:24
@github-actions
Copy link

github-actions bot commented Jun 7, 2025

Playwright test results

passed  39 passed

Details

stats  39 tests across 4 suites
duration  
commit  1d43d5a

daun added 4 commits June 8, 2025 09:41
Signed-off-by: Philipp Daun <post@philippdaun.net>

# Conflicts:
#	package-lock.json
#	src/index.ts
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
@daun
Copy link
Member

daun commented Jun 8, 2025

Added two items to the list:

  • Support scrolling nested containers
  • Improve API around replacing swup's internal scrollTo handler

daun added 3 commits June 8, 2025 22:27
Add support for nested scroll containers
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
hirasso and others added 13 commits June 29, 2025 14:00
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Apply scroll position via custom scroll function
@hirasso hirasso marked this pull request as ready for review August 4, 2025 14:02
@hirasso hirasso requested a review from daun August 4, 2025 15:29
@hirasso
Copy link
Member Author

hirasso commented Aug 4, 2025

One more "yes" please :)

daun
daun previously approved these changes Aug 4, 2025
Copy link
Member

@daun daun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yes 🔥

@hirasso
Copy link
Member Author

hirasso commented Aug 4, 2025

Sorry... one more time 😅

Copy link
Member

@daun daun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@hirasso hirasso merged commit c5afa70 into main Aug 4, 2025
4 checks passed
@hirasso hirasso deleted the next branch August 4, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants