Skip to content

feat: publish datasource as replacement #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacalata merged 3 commits into from
Dec 30, 2024
Merged

feat: publish datasource as replacement #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f00de0
Add "Replace" to publish type enum
jacalata Nov 20, 2024
a3bd630
unit test
jacalata Dec 10, 2024
8cf8226
Update datasources_endpoint.py
jacalata Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tableauserverclient/server/endpoint/datasources_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,12 @@ def publish(
else:
raise TypeError("file should be a filepath or file object.")

if not mode or not hasattr(self.parent_srv.PublishMode, mode):
error = "Invalid mode defined."
raise ValueError(error)

# Construct the url with the defined mode
url = f"{self.baseurl}?datasourceType={file_extension}"
if mode == self.parent_srv.PublishMode.Overwrite or mode == self.parent_srv.PublishMode.Append:
if not mode or not hasattr(self.parent_srv.PublishMode, mode):
error = f"Invalid mode defined: {mode}"
raise ValueError(error)
else:
url += f"&{mode.lower()}=true"

if as_job:
Expand Down
1 change: 1 addition & 0 deletions tableauserverclient/server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ class PublishMode:
Append = "Append"
Overwrite = "Overwrite"
CreateNew = "CreateNew"
Replace = "Replace"

def __init__(self, server_address, use_server_version=False, http_options=None, session_factory=None):
self._auth_token = None
Expand Down
Loading