Skip to content

add JobItem.FinishCode.Completed #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fenimore wants to merge 4 commits into from
Closed

add JobItem.FinishCode.Completed #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42cecfe
Merge pull request #1555 from tableau/development
jacalata Jan 10, 2025
026c6cd
Try with completed
fenimore Mar 6, 2025
65ac5cb
Add completed unittest
fenimore Mar 6, 2025
b6925a3
Merge branch 'development' into master
jacalata Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/assets/job_get_by_id_completed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
<statusNote type="CountOfUsersAddedToGroup" value="5" text="Description of how many users were added to the group during the import." />More detail
</statusNotes>
</job>
</tsResponse>
</tsResponse>
1 change: 1 addition & 0 deletions test/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def test_wait_for_job_completed(self) -> None:
self.assertEqual(job_id, job.id)
self.assertListEqual(job.notes, ["Job detail notes"])


def test_wait_for_job_failed(self) -> None:
# Waiting for a failed job raises an exception
response_xml = read_xml_asset(GET_BY_ID_FAILED_XML)
Expand Down
Loading