Skip to content

sqlite: don't interrupt a running query if closed #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knyar merged 1 commit into from
Feb 5, 2026
Merged

sqlite: don't interrupt a running query if closed #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sqlite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,11 @@ func (s *stmt) ExecContext(ctx context.Context, args []driver.NamedValue) (drive
// Note: We respond to cancellation on the primary context (ctx) not
// the cleanup context (pctx).
if ctx.Err() != nil {
db.Interrupt()
if s.closed.Load() {
UsesAfterClose.Add("stmt.ExecContext.Interrupt", 1)
} else {
db.Interrupt()
}
Comment on lines +582 to +586
Copy link
Member

@bradfitz bradfitz Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still a potential race here. we need to hold a mutex during Interrupt + Close.

}
})

Expand Down Expand Up @@ -652,7 +656,11 @@ func (s *stmt) QueryContext(ctx context.Context, args []driver.NamedValue) (driv
// Note: We respond to cancellation on the primary context (ctx) not
// the cleanup context (pctx).
if ctx.Err() != nil {
db.Interrupt()
if s.closed.Load() {
UsesAfterClose.Add("stmt.QueryContext.Interrupt", 1)
} else {
db.Interrupt()
}
}
})
// In this case we do not have an early exit, so we don't need to
Expand Down
Loading