Boolean parsing is broken with Postgres#9
Open
backspace wants to merge 3 commits intotchak:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not opening this to actually be merged, just to highlight the problem. I found that I couldn’t get a
truevalue from a boolean field and it seems like a difference between what’s returned from the in-memory SQLite database in tests vs Postgres.It’s possible the
Boolean(value)change is sufficient but there’s a lot of ceremony here just to get tests running on CI with Postgres, I don’t know that it’s worth having it all, or if it is, it would need to be completed.generateIdfailedI showed it failing when I added a boolean to the schema and made its value true in the example author. Then it passed with the change to boolean handling.