Skip to content

Conversation

@LINYV0719
Copy link

Description

This PR adds a missing unit test export_saved_model_test.py to verify that ExportFileManager.clean_up correctly handles negative max_to_keep values (early return).

So I added test_export_file_manager_negative_max_to_keep to verify that no files are deleted when max_to_keep is negative.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

[x] Other (Test coverage improvement)

Tests

I verified the changes by running the unit tests and generating a coverage report.

Test Configuration:

OS: Windows 11
Python Version: 3.10
Command:
python -m orbit.actions.export_saved_model_test
coverage run --source=orbit -m orbit.actions.export_saved_model_test

Checklist

@LINYV0719 LINYV0719 requested a review from a team as a code owner January 3, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant