[Orbit] Achieve 100% test coverage for export_saved_model #13597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a missing unit test export_saved_model_test.py to verify that ExportFileManager.clean_up correctly handles negative max_to_keep values (early return).
So I added test_export_file_manager_negative_max_to_keep to verify that no files are deleted when max_to_keep is negative.
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
[x] Other (Test coverage improvement)
Tests
I verified the changes by running the unit tests and generating a coverage report.
Test Configuration:
OS: Windows 11
Python Version: 3.10
Command:
python -m orbit.actions.export_saved_model_test
coverage run --source=orbit -m orbit.actions.export_saved_model_test
Checklist