This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Draft
Conversation
DEKHTIARJonathan
force-pushed
the
master
branch
from
951f264 to
65ed25c
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
4 times, most recently
from
dd03467 to
653ea0a
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
3 times, most recently
from
cf30938 to
8d2c59f
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
from
064de53 to
eb97b19
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
3 times, most recently
from
27ef7b8 to
535c132
Compare
Contributor
|
@meena-at-work: for review |
Contributor
meena-at-work
left a comment
meena-at-work
left a comment
There was a problem hiding this comment.
Overall, it looks fine to me as is -- considering that it is intended to be a standalone example of using synthetic data (and not a benchmark). If you can address the one small nit, I think it's good to go.
| // Converts an MNIST Image to a tensorflow Tensor. | ||
| tensorflow::Tensor MNISTImageToTensor(int offset, int batch_size); | ||
|
|
||
| std::vector<mnist::MNISTImage> images; |
Contributor
There was a problem hiding this comment.
just a nit here -- can you name the member variables with a m_images or images_ so we know that they're member variables?
DEKHTIARJonathan
force-pushed
the
master
branch
4 times, most recently
from
cf4f9f4 to
0f999c4
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
8 times, most recently
from
e8da9e9 to
a742619
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
5 times, most recently
from
f8c43a2 to
41bbfde
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
from
6cf16c4 to
ccc606f
Compare
DEKHTIARJonathan
force-pushed
the
master
branch
13 times, most recently
from
0c12576 to
bfed396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test program to run TF-TRT conversion with the C++API with synthetic data.
This is based on #271
Todo