Remove contradiction from documentation#1430
Open
skonky wants to merge 1 commit intotesting-library:mainfrom
Open
Remove contradiction from documentation#1430skonky wants to merge 1 commit intotesting-library:mainfrom
skonky wants to merge 1 commit intotesting-library:mainfrom
Conversation
remove the part that tells you to install @testing-library/dom because it is already included when using a framework wrapper
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
skonky
commented
Sep 24, 2024
|
|
||
| To get started with `React Testing Library`, you'll need to install it together | ||
| with its peerDependency `@testing-library/dom`: | ||
| To get started with `React Testing Library`, you'll need to install it. |
Author
There was a problem hiding this comment.
maybe this text can even be removed as it's kind of stating the obvious
Member
|
Hi @skonky, thanks for this. |
Author
|
@MatanBobi Cool, I will update the docs to say the opposite of what I did in the current commit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found something confusing in the documentation regarding testing-library-dom
Here you say that testing-library-dom should be resolved via the framework wrapper
And when you then go to the actual framework wrapper (in my case react) it states the following:
but this contradicts what is said earlier right?