Handle invalid player configs by regenerating defaults #201
Conversation
…xitlevel-routine Harden ExitLevel intermission screenshot handling
…on-error-in-g_main.cpp Fix map list shuffle format usage
…ion-error Fix screenshot command format strings
…nment-in-spawnentities Ensure override checks see updated map name
…ion-in-spawnentities Reset num_entities after clearing entity array
…to-manage-server_flags Ensure server loading flag persists through initialization
…on-in-spawnentities
…alue-initialization-in-spawnentities Add helper to reset level struct safely
…s-for-code-reuse Refactor SpawnEntities entity parsing
…opulation-after-reset Preserve level entity string
…-conversion-in-intermission-code Fix intermission angles
…nt-in-pitch-adjustments Guard intermission pitch hacks when spawn missing
…nitgame Clamp maxclients before allocations
…nd-entries Add null check for menu status bar entries
…nt-in-p_menu_buildstatusbar Adjust status bar caret alignment
…ng-logic-for-serialization Restore writeip persistence
…-helper-and-replace-push/pop Add RAII guard for JSON stack handling
…er-fatal-error-handling Stop emitting JSON warnings after fatal errors
…th_max-to-float-before-division Fix vampiric regen cap rounding and add regression test
…ain-behavior-and-add-unit-test Handle empty horde rosters in life check
…ndlymessage-for-spectators Ensure spectators inherit team chat prefix
…in-main Reset shared state between CTF flag tests
…ers.social_id Sanitize player social id for config paths
…file-in-pcfg_clientinitpconfig Parse and apply player config settings
…string-write-in-pcfg_writeconfig Restore validation and writing for player config output
…itpconfig-for-ftell-handling Handle pcfg file length errors
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| if (buffer && length) { |
There was a problem hiding this comment.
The added closing brace at this point ends the if (f != NULL) block before the subsequent if (buffer && length) check, but length is declared inside that block (near the fseek/ftell setup). Once the block is closed, length is out of scope where it is referenced, so the file no longer compiles—any build will fail in PCfg_ClientInitPConfig until the parsing logic and its variables remain in the same scope.
Useful? React with 👍 / 👎.
ozy24
force-pushed
the
main
branch
2 times, most recently
from
e51338e to
c2adaf5
Compare
Summary
Testing
Codex Task