File parsing: Option to raise exception instead of warning#520
Open
mtmail wants to merge 1 commit intotheskumar:mainfrom
Open
File parsing: Option to raise exception instead of warning#520mtmail wants to merge 1 commit intotheskumar:mainfrom
mtmail wants to merge 1 commit intotheskumar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dealed with an
.envfile that accidentially contained an unparsable line (example:datebase_name='some_value). The software which usedpython-dotenvfor configuration then set a default value and I almost wrote to a wrong database.Related to #467 which also asks for an option to raise an error instead of just issuing a warning on parse errors.
Happy to change the variable naming and open to other feedback you may have.
Tests including linting pass.