Conversation
lyakh
requested review from
abonislawski,
dbaluta,
jxstelter,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart,
ranj063 and
singalsu
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR continues the automated removal of function names from debug/log messages across the audio module codebase. The changes standardize logging by replacing function-specific names with generic "entry" or contextual descriptions.
- Replace function names in debug/info messages with generic "entry" or descriptive text
- Remove function names from error messages while preserving context
- Clean up debug message formatting and remove redundant information
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/audio/src/src_lite.c | Replace src_prepare() with entry in debug message |
| src/audio/src/src_ipc4.c | Replace function names with entry in debug messages and remove function names from context messages |
| src/audio/src/src_ipc3.c | Replace src_init() with entry in debug message |
| src/audio/src/src_common.c | Replace function names with entry and remove function names from info/error messages |
| src/audio/src/src.c | Replace src_prepare() with entry in info message |
| src/audio/module_adapter/module_adapter.c | Replace function names with contextual messages and clean up function formatting |
| src/audio/module_adapter/module/passthrough.c | Standardize debug messages to use entry and reposition one debug call |
| src/audio/module_adapter/module/modules.c | Replace function names with entry in info messages |
| src/audio/module_adapter/module/generic.c | Replace function names with entry/done and remove function names from error messages |
| src/audio/mixin_mixout/mixin_mixout.c | Replace function names with entry and remove function names from error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| int ret; | ||
|
|
||
| comp_info(dev, "mixin_prepare()"); | ||
| comp_dbg(dev, "entry"); |
There was a problem hiding this comment.
This line changes from comp_info to comp_dbg, which reduces the log level. This appears to be an unintended change as other similar replacements in the PR maintain the same log level (info vs dbg).
| comp_dbg(dev, "entry"); | |
| comp_info(dev, "entry"); |
|
Seems other PRs are not ready to go in today, so let's put this in now. |
|
Or wait , @lyakh can you check the internal CI check? That's failing for this as well. Hard to see how this can be related, but given it's a mandatory check, cannot bypass. |
|
ping @lrudyX - good to merge ? |
Looks like one test crashes. I need to do some more tries. I will let you know. |
|
Failed: |
|
@lrudyX not expecting this to fail since its a string change PR. False positive ? |
We have random fails in different tests in few tries. I think those are false positives. |
Remove left-over function names in log prints in generic.c, also remove component ID prints in comp_*() calls because they print the ID automatically. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove function names from logging and merge needlessly split lines. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove function names from logging, missed by automation. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove function names from logging, missed by automation. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove function names from logging, missed by automation. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
7 participants
automation didn't remove all function names. We'll script-remove the rest, here so far a couple that just were standing in the way.