audio: base_fw: fix race condition in perf counters reset operation#10250
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Sep 22, 2025
Merged
audio: base_fw: fix race condition in perf counters reset operation#10250lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Change the order of operations in the performance measurement initialization sequence to avoid a race condition. Previously, the performance counters were reset before setting the state to STOPPED, which created a window where an LL task could preempt the execution and record new measurements between these operations. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This change fixes a race condition in the performance measurement initialization sequence by reordering operations. The fix ensures that performance counters are reset after setting the state to STOPPED rather than before, preventing low-latency tasks from recording measurements during the transition window.
Key Changes
- Reordered performance counter reset to occur after state transition
- Eliminated race condition window where LL tasks could interfere with initialization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lgirdwood
approved these changes
Sep 22, 2025
tmleman
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the order of operations in the performance measurement initialization sequence to avoid a race condition.
Previously, the performance counters were reset before setting the state to STOPPED, which created a window where an LL task could preempt the execution and record new measurements between these operations.