topology2: include: common: pcm: Add quotes for string values#10256
Merged
kv2019i merged 1 commit intothesofproject:mainfrom Sep 25, 2025
Merged
topology2: include: common: pcm: Add quotes for string values#10256kv2019i merged 1 commit intothesofproject:mainfrom
kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
Add quotes around the valid values for direction to prevent compilation errors with the latest alsa-lib that fails with the error: ALSA lib conf.c:1224:(parse_value) id is not an integer ALSA lib conf.c:2014:(_snd_config_load_with_include) _toplevel_:224:17:Unexpected char Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
Fixes compilation errors with the latest alsa-lib by adding quotes around string values in the PCM configuration. The change addresses parsing errors where unquoted string identifiers were being treated as integers.
- Adds quotes around the valid values for direction attribute in PCM configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kv2019i
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quotes around the valid values for direction to prevent compilation errors with the latest alsa-lib that fails with the error: ALSA lib conf.c:1224:(parse_value) id is not an integer ALSA lib conf.c:2014:(_snd_config_load_with_include) toplevel:224:17:Unexpected char