audio: copier: Refactor deep copy of copier config #10445
Merged
+26
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch?
|
wjablon1
force-pushed
the
copier_ref
branch
3 times, most recently
from
ded58aa to
9e431b0
Compare
wjablon1
requested review from
RanderWang,
abonislawski,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko,
plbossart and
tmleman
as code owners
Contributor
|
SOFCI TEST |
Member
|
@wjablon1 there is some red on the CI, can you check. Thanks ! |
Member
|
Jenkins stuck, restart it. |
Member
|
SOFCI TEST |
Code for copying copier_data is ambiguous. A comment suggests that the deep copy (data structure + variable-length array) is not needed but the copy of the variable-length array is performed afterwards. This change rectifies this by placing ipc4_copier_module_cfg at the end of copier_data structure as it contains the variable-length array. This enables single memory allocation and single 1:1 copy for the complete copier_data with the variable-length addition. Signed-off-by: Wojciech Jablonski <wojciech.jablonski@intel.com>
tmleman
approved these changes
Dec 22, 2025
lgirdwood
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for copying copier_data is ambiguous. A comment suggests that the deep
copy (data structure + variable-length array) is not needed but the copy of
variable-length array is performed afterwards. This change rectifies this by
placing ipc4_copier_module_cfg at the end of copier_data structure as it
contains a variable-length array. This enables single memory allocation and
single, clean 1:1 copy for the complete copier_data with the variable-length
addition.