Skip to content

Conversation

@NicholasTanz
Copy link
Contributor

Description of the changes being introduced by the pull request:

Fixes #2722

Signed-off-by: NicholasTanz <nicholastanzillo@gmail.com>
@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11658095629

Details

  • 64 of 64 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 96.61%

Totals Coverage Status
Change from base Build 11568736074: 0.004%
Covered Lines: 1572
Relevant Lines: 1609

💛 - Coveralls

Signed-off-by: NicholasTanz <nicholastanzillo@gmail.com>
@NicholasTanz NicholasTanz marked this pull request as ready for review November 4, 2024 04:32
@NicholasTanz NicholasTanz requested a review from a team as a code owner November 4, 2024 04:32
@NicholasTanz
Copy link
Contributor Author

Hi @jku, when you have a moment, could you take a look at this PR. thanks

@jku
Copy link
Member

jku commented Nov 19, 2024

Sorry, I've been distracted. This seems good but I'll take a closer look this week.

Maybe I'll also check with some downstream users if bumping minimum python is ok with them or if we need to still wait a bit before merging...

@NicholasTanz
Copy link
Contributor Author

NicholasTanz commented Nov 19, 2024

No worries, thank you for reviewing my PRs! Let me know if there's anything I can do to help

@kairoaraujo
Copy link
Contributor

Thank you @NicholasTanz for the PR

LGTM (it was on my TODO list too)

I will let @jku look at it before I merge it.

@jku
Copy link
Member

jku commented Nov 29, 2024

Thanks a lot, sorry for delays.

I might still add a from __future__ import annotations before next release (since it would not break compat with 3.8 and will give us even more nice annotations from 3.10) but I think this PR is good either way

@jku jku merged commit f2aeb97 into theupdateframework:develop Nov 29, 2024
16 checks passed
@NicholasTanz NicholasTanz deleted the updateAnnotations branch November 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update container annotations

4 participants