Skip to content

Conversation

@dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Dec 9, 2025

My App has a feature to remove and add tinymce same editor again (see video).
But second time adding not working since in global tinyMCE object previous editor didn't remove properly, for tinyMCE it was already initialized
Screencast_20251209_180118.webm

Please make a new release once merged

@dmitryuk dmitryuk requested a review from a team as a code owner December 9, 2025 11:03
@dmitryuk dmitryuk requested review from TheSpyder, ltrouton and spocke and removed request for a team December 9, 2025 11:03
@dmitryuk dmitryuk changed the title Fix editor disconnected not destroyed Fix disconnected editor not destroyed Dec 9, 2025
@dmitryuk
Copy link
Contributor Author

@spocke @TheSpyder @ltrouton please review

@tiny-ben-tran
Copy link
Contributor

@dmitryuk The PR looks good so far. Could you add some tests?

@dmitryuk
Copy link
Contributor Author

@tiny-ben-tran tests added

@tiny-ben-tran
Copy link
Contributor

In case you haven't signed a CLA:

Hello @dmitryuk,

Thank you for your code contribution to this project, Tiny would like to publish and acknowledge your code contribution to the TinyMCE-Webcomponent open source project in the next release. For Tiny to proceed, we will need permissions from you to use your code. Could you email legal@tiny.cloud with the subject CLA request for dmitryuk. Our legal team will send you a Contributors License Agreement (CLA) that gives Tiny permissions to use your code.

Thanks again for your contributions

dmitryuk and others added 2 commits December 16, 2025 10:54
Co-authored-by: tiny-ben-tran <ben.tran@tiny.cloud>
Co-authored-by: tiny-ben-tran <ben.tran@tiny.cloud>
@dmitryuk
Copy link
Contributor Author

In case you haven't signed a CLA:

Hello @dmitryuk,

Thank you for your code contribution to this project, Tiny would like to publish and acknowledge your code contribution to the TinyMCE-Webcomponent open source project in the next release. For Tiny to proceed, we will need permissions from you to use your code. Could you email legal@tiny.cloud with the subject CLA request for dmitryuk. Our legal team will send you a Contributors License Agreement (CLA) that gives Tiny permissions to use your code.

Thanks again for your contributions

CLA signed and sent

@tiny-ben-tran tiny-ben-tran merged commit a0ef913 into tinymce:main Dec 18, 2025
5 checks passed
@dmitryuk
Copy link
Contributor Author

@tiny-ben-tran please make a new release

@tiny-ben-tran
Copy link
Contributor

@dmitryuk 2.3.2 is now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants