Initialize arrays with NaN for easier error detection#90
Open
andreasnoack wants to merge 1 commit intotpapp:masterfrom
Open
Initialize arrays with NaN for easier error detection#90andreasnoack wants to merge 1 commit intotpapp:masterfrom
andreasnoack wants to merge 1 commit intotpapp:masterfrom
Conversation
Owner
|
Hmm, I was hoping we would catch errors with random tests, but I do see the rationale behind doing something like this. I am wondering if this would work for float types that have no equivalent of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NaNs will make it immediately obvious when some memory hasn't been properly set. I had a case where zero was the correct value so most often the random memory happened to have the correct value. Except on CI where it received memory that made the tests fail.