Update sources in Package.swift to include scanner.c#330
Open
zxss702 wants to merge 1 commit intotree-sitter:masterfrom
Open
Update sources in Package.swift to include scanner.c#330zxss702 wants to merge 1 commit intotree-sitter:masterfrom
zxss702 wants to merge 1 commit intotree-sitter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical build issue when using this repository as a remote dependency via Swift Package Manager (SwiftPM).
The Issue
Currently,
Package.swiftusesFileManager.default.fileExists(atPath: "src/scanner.c")to conditionally append the scanner to thesourcesarray. However, there is a known limitation with SwiftPM: when this package is included as a dependency in another project, SwiftPM evaluates relative paths based on the root project's working directory, not the dependency's directory.Because of this,
fileExistsreturnsfalse, causing the scanner to be entirely omitted from the compilation process. This ultimately results inUndefined symbols for architecture... _external_scanner_...linker errors in downstream projects.The Fix
FileManagercheck.src/scanner.c(and other required source files) in thesourcesarray of the target.This simple change ensures the package compiles correctly and links all required symbols regardless of how or where it is integrated via SwiftPM.