Update atomic-deployment.mdx

[loganmimaroglu]

Changelog

Updating docs

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue in our deployment automation that prevented task updates from being promoted. With this fix, new versions are now automatically and reliably promoted, ensuring you receive the latest improvements without disruption.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d28f403

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This change removes the if: false condition from the "Promote Trigger.dev Version" step in the GitHub Actions workflow. By doing so, the command npx trigger.dev@latest promote $TRIGGER_VERSION is enabled to run, ensuring that the promotion of the specified Trigger.dev version now occurs. Environment variables remain intact, preserving the necessary access token configuration.

Changes

File	Change Summary
docs/deployment/atomic-deployment.mdx	Removed the if: false condition from the "Promote Trigger.dev Version" step, enabling execution of the promotion command without altering environment variables.

Sequence Diagram(s)

sequenceDiagram
  participant GHA as GitHub Actions
  participant Step as Promote Step
  participant CLI as Promotion Command
  
  GHA->>Step: Evaluate step condition (previously skipped)
  Step->>CLI: Execute `npx trigger.dev@latest promote $TRIGGER_VERSION`
  CLI-->>Step: Return promotion result
  Step-->>GHA: Pass result back to workflow

Loading

Possibly related PRs

• fix: needsPromotion fixed in deploy github actions #1741: Adjusts the logic for determining the needsPromotion property, impacting the deployment process.
• docs: improve deployment docs and add atomic deploy guide #1748: Introduces documentation for the promote command, aligning with the changes that enable version promotion.

Suggested reviewers

• ericallam

Poem

I'm a little rabbit, hopping with glee,
Seeing our promotion step run free.
No more "if: false" to hold things back,
Now commands execute right on track.
Cheers to new code and a workflow so spry—
Happy hops, under a code-clear sky!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa0e2bf and d28f403.

📒 Files selected for processing (1)

• docs/deployment/atomic-deployment.mdx (0 hunks)

💤 Files with no reviewable changes (1)

• docs/deployment/atomic-deployment.mdx

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matt-aitken]

@loganmimaroglu can you provide more information about this change?

[loganmimaroglu]

Hey @matt-aitken, I think the if: false condition is preventing the trigger deployment from ever being promoted. Removing that conditional should allow the trigger deployment to be promoted after the Vercel deployment completes successfully.