-
-
Notifications
You must be signed in to change notification settings - Fork 1k
improv(webapp): Add new table for optimized logs search #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d322cec
a614149
5eca0e3
cc6dc02
51d5852
f3534c4
51ceac9
b9324cd
8dd9258
58022cc
96163c6
9a83b02
be9888d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚩 CANCELLED status SPANs are unreachable by any level filter The
(Refers to lines 298-301) Was this helpful? React with 👍 or 👎 to provide feedback.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will be figured out in the future after some alpha testing in prod. This status is not that used and we might not want to filter by it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Partition pruning with
inserted_atis ineffective on the new search tableThe LogsListPresenter applies
inserted_at >= ...andinserted_at <= ...filters (lines 269-271, 282-284). On the oldtask_events_v2table, these were effective for partition pruning since it usedPARTITION BY toDate(inserted_at)(010_add_task_events_v2.sql:48). However, the newtask_events_search_v1table usesPARTITION BY toDate(triggered_timestamp)(016_add_task_events_search_v1.sql:26). Theinserted_atfilter will still execute correctly but won't help prune partitions, making it dead weight. For effective partition pruning, the time range filter should targettriggered_timestampinstead. Thestart_timefilters that are also applied are close totriggered_timestamp(sincetriggered_timestamp = start_time + duration) but won't trigger partition pruning either since they reference a different column. This won't cause incorrect results but may degrade query performance for large datasets.(Refers to lines 266-289)
Was this helpful? React with 👍 or 👎 to provide feedback.