Open
Conversation
eliassjogreen
requested changes
Dec 8, 2024
eliassjogreen
requested changes
Dec 8, 2024
eliassjogreen
requested changes
Dec 8, 2024
…thub.io into blog-preview2
eliassjogreen
requested changes
Dec 8, 2024
components/Markdown.css
Outdated
Comment on lines
42
to
51
| p>code { | ||
| background-color: light-dark(hsl(230, 1%, 98%), hsl(220, 13%, 18%)); | ||
| outline: 0.15em solid light-dark(hsl(230, 1%, 98%), hsl(220, 13%, 18%)); | ||
| } | ||
|
|
||
| pre:has(code) { | ||
| outline: 1rem solid var(--neutral-100); | ||
| background-color: var(--neutral-100); | ||
| outline: 1rem solid light-dark(hsl(230, 1%, 98%), hsl(220, 13%, 18%)); | ||
| background-color: light-dark(hsl(230, 1%, 98%), hsl(220, 13%, 18%)); | ||
| overflow: auto; | ||
| } |
Member
There was a problem hiding this comment.
suggestion: What are these colors? Let's try to use the same bg colors as before if it still looks good. Otherwise at least make them variables.
components/Markdown.css
Outdated
| background-color: var(--neutral-400); | ||
| -webkit-border-radius: 3px; | ||
| } | ||
| } No newline at end of file |
components/Markdown.css
Outdated
Comment on lines
4
to
10
| >*:first-child { | ||
| margin-top: 0 !important; | ||
| } | ||
|
|
||
| > *:last-child { | ||
| >*:last-child { | ||
| margin-bottom: 0 !important; | ||
| } |
Member
There was a problem hiding this comment.
nitpick: Revert formatting
Comment on lines
+2
to
+3
| * One Dark theme & One Light theme for prism.js stolen and meddled with for this site | ||
| * Based on Atom's One Dark theme: https://github.com/atom/atom/tree/master/packages/one-dark-syntax |
Member
There was a problem hiding this comment.
issue: Add proper attribution or simply import the CSS directly from there.
public/prism.css
Outdated
Comment on lines
245
to
260
| /* Styling the buttons */ | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>button, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>a, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>span { | ||
| background: light-dark(hsl(230, 1%, 90%), hsl(220, 13%, 26%)); | ||
| color: light-dark(hsl(230, 6%, 44%), hsl(220, 9%, 55%)); | ||
| padding: 0.1em 0.4em; | ||
| border-radius: 0.3em; | ||
| } | ||
|
|
||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>button:hover, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>button:focus, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>a:hover, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>a:focus, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>span:hover, | ||
| div.code-toolbar>.toolbar.toolbar>.toolbar-item>span:focus { |
Member
There was a problem hiding this comment.
suggestion: Looks an awful lot like a place where you could just use CSS nesting.
Comment on lines
+368
to
+369
| /* Previewers plugin overrides */ | ||
| /* Based on https://github.com/atom-community/atom-ide-datatip/blob/master/styles/atom-ide-datatips.less and https://github.com/atom/atom/blob/master/packages/one-dark-ui */ |
Member
There was a problem hiding this comment.
nitpick: Comment formatting and proper attribution.
eliassjogreen
requested changes
Dec 8, 2024
| langPrefix: "language-", | ||
| highlight(code, lang, _info) { | ||
| lang = languageAliases[lang] ?? lang; | ||
| const language = Prism.languages[lang] ?? Prism.languages.autoit; |
Member
There was a problem hiding this comment.
question: Isn't autoit the hotkey language? You should default to no highlighting.
Member
Author
There was a problem hiding this comment.
isnt our default language the autohotkey language?
Member
Author
There was a problem hiding this comment.
nah wait wrong language its this one https://www.autoitscript.com/site/autoit/
eliassjogreen
requested changes
Dec 8, 2024
Co-authored-by: Elias Sjögreen <elias@5monkeys.se>
…thub.io into blog-preview2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.