Support variants (types defined with '#type')#4
Open
bloeys wants to merge 1 commit intotsoding:masterfrom
Open
Support variants (types defined with '#type')#4bloeys wants to merge 1 commit intotsoding:masterfrom
bloeys wants to merge 1 commit intotsoding:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
hope you are doing well!
This is a small PR to add support for type variants (e.g.,
Id :: #type,distinct int) when parsing or producing JSON.I also added tests for this.
Btw I do not think
variant_ofcan ever be null, but if yes, then we need to adjust the while loop to check info for null first.Side note: I expect a loop similar to this approach for pointer handling should be a bit faster than the current dereference-by-recursion.
Thanks :)