Potential solution for DELETE_OLD on Windows#116
Open
ThenTech wants to merge 1 commit intotsoding:mainfrom
Open
Potential solution for DELETE_OLD on Windows#116ThenTech wants to merge 1 commit intotsoding:mainfrom
ThenTech wants to merge 1 commit intotsoding:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comment in #111.
Changes:
_CRT_SECURE_NO_WARNINGSif already defined (by cl.exe commands)MOVEFILE_WRITE_THROUGHinnob_renameso the function doesn't return until the file is actually written--nob-delete-oldargument to tell the new nob to delete the old one, and run the new one async, so the old one can exit and release its own process handle