-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: πΈ added higher resoulution options in the dateTime Filter #16548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: πΈ added higher resoulution options in the dateTime Filter #16548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 11 files
|
π Preview Environment Ready! Your preview environment is available at: http://bore.pub:41106 This environment will automatically shut down when the PR is closed or after 5 hours. |
|
Is that something we want to add in the UI @Bonapara ? (the more options, the messier it can feel) |
|
I think it is a great addition but:
|
|
Great. I will let you implement those feedback @Bhoomaahamso . But that's a great addition to our CRM. thanks for the work
|
|
Hi @Bonapara @guillim , For point 2, both |
-> ['Day', 'Week', 'Month', 'Year', 'Hour', 'Minute', 'Second']
-> yes please. in the same file will be fine. |
Title: "feat: Add second, minute & hour resolution options to relative date Filter action"
Summary
This PR enables support for smaller time units β Seconds, Minutes, and Hours β in the Relative Date filter used in workflows, rather than being limited to days only.
What Changed
This PR extends the relative date filter to include support for the following units:
βοΈ
SECONDβοΈ
MINUTEβοΈ
HOURβοΈ (Existing:
DAY,WEEK,MONTH, etc.)Changes include:
SECOND,MINUTE, andHOURoptions to the internal relative date unit enum/constant.Testing
New and updated tests include:
Tests are included in the changeset.
Backward Compatibility
This change is fully backward compatible:
Issue Reference
Fixes: #15525