fix(documents): split import batch sizing into server and client params#125
Open
tharropoulos wants to merge 2 commits intotypesense:masterfrom
Open
fix(documents): split import batch sizing into server and client params#125tharropoulos wants to merge 2 commits intotypesense:masterfrom
tharropoulos wants to merge 2 commits intotypesense:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
batch_sizeas the server-side import query parameter and forward it via merged import parametersclient_batch_sizefor client-side chunking, update overloads, docs, types, and sync/async tests for both code pathsdocuments.Documents.import_()batch_sizeargument is ignored, type ofimport_parametersis missingbatch_size#124PR Checklist