Avoid infinite recursion on 'markdown' fence #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyru
added a commit
to tyru/vim-markdown
that referenced
this pull request
Oct 28, 2018
This is reported by @rhysd. tyru/markdown-codehl-onthefly.vim#3
Owner
|
ｳｵｵ、ありがとうございます… 確認できました。 ただこれは tpope/vim-markdown 側で対応すべき問題のような気がします。 とりあえず PR 出してみました。 |
Contributor
Author
|
ありがとうございます．確かに大元でチェックした方が良いですね．こちらの PR は一旦閉じておきますが，もし必要になったら適宜 reopen ください |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown ファイルの中に
markdownフェンスがあると自身と同じファイルタイプの構文ハイライトを再帰的に include しつづけてエラーになってしまうようです（Vim 8.1.26 on macOS で確認）これは Vim のハイライトの include の仕組み上避けられないので，
markdownを除外する処理を行いました．