add attributes to QueryOptions

[kldeb]

No description provided.

[netlify]

✅ Deploy Preview for electrodb-dev canceled.

Name	Link
🔨 Latest commit	2529989
🔍 Latest deploy log	https://app.netlify.com/sites/electrodb-dev/deploys/6747d281e2608600089a6e2d

[kldeb]

@tywalch is there something else required?

[tywalch]

Hi @kldeb 👋

Sorry I haven't had a chance to respond. Thanks for putting together a PR! Unfortunately, the typing added to this PR does not have a valid typescript syntax. There is a reference to a non-existent Attributes type. If you check out how this is accomplished for queries, you'll see it requires more legwork to get the list of valid attribute names for the options. Lastly, there is a pattern of type tests for additions like this, and tests would be required to merge a change like this.

I appreciate your willingness to contribute to the project; changes like this can be challenging for any outside contributor because of the library's approach to strong inference.

[kldeb]

Thanks @tywalch. I was looking for a typecheck command to run. I've since found test:types. I will try to find some time to dig in deeper. This is an intense level of typing!

[tywalch]

Thanks @tywalch. I was looking for a typecheck command to run. I've since found test:types. I will try to find some time to dig in deeper. This is an intense level of typing!

@kldeb Yeah "insane" in the way that only an insane person would have written it 🤪

[anatolzak]

@kldeb the fix to this issue has been merged via #470