fix: pass deferRegistry to renderHTML during SSR#63
Merged
Conversation
DeferredComponent crashed during SSR because deferRegistry was never passed to ssrEntryModule.renderHTML(), causing the RegistryContext to be undefined and the component to fall through to a client-side fetch path that fails on the server. Add e2e test fixture with SSR + defer() to prevent regression. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeferredComponentcrash during SSR by passingdeferRegistrytorenderHTML()in both dev SSR and build pathsdefer()to prevent regressionplaywright-report-dev/directoryDetails
When SSR is enabled and a deferred component (created via
defer()) is rendered,DeferredComponentcrashes becauserenderEntryToResponse()andbuild()inrsc/entry.tsxnever passeddeferRegistrytossrEntryModule.renderHTML(). The SSR entry wraps the tree in<RegistryContext value={options.deferRegistry}>, but sincedeferRegistrywas never passed, the context wasundefined. WhenDeferredComponentrenders during SSR, it saw no registry and fell through to the client-sidefetch()path, which fails because relative URLs have no base on the server.Test plan
pnpm buildsucceedspnpm test:e2e— 19 passed (including 2 new ssr-defer tests)pnpm test:e2e:dev— 19 passed (including 2 new ssr-defer tests)🤖 Generated with Claude Code