fix: resolve ReadableStream locked error during build with defer()#64
Merged
fix: resolve ReadableStream locked error during build with defer()#64
Conversation
During vite build, DeferredComponent in SSR calls registry.load() which locks stream1 via createFromReadableStream. Later, loadAll() tried to drain the same locked stream, causing ERR_INVALID_STATE. Fix by storing a drainPromise (from draining stream2 of the tee) on each DeferEntry, and having loadAll() await these promises instead of attempting to drain the potentially-locked stream1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite build,DeferredComponentrendered in SSR callsregistry.load(), which locksstream1(fromstream.tee()) viacreateFromReadableStream. Later,loadAll()attempted to drain the same locked stream, causingERR_INVALID_STATE: ReadableStream is locked.drainPromise(from drainingstream2of the tee) on eachDeferEntry, and havingloadAll()await these promises instead of attempting to drain the potentially-lockedstream1.loadAll()by removing the per-state switch in favor of uniformly awaiting drain promises.Test plan
pnpm buildsucceeds (including docs and example packages that usedefer())pnpm test:e2e), including SSR defer tests🤖 Generated with Claude Code