fix: handle { port: "0" }
#105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being passed `{ port: '0' }` (`{ port: string }`) is a Typescript type
error, but we explicitly have a test that checks that it is gracefully
handled, with behavior matching being passed
- `{ port: 0 }` (`{ port: number }`),
- `'0'` (`string`), or
- `0` (`number`),
which all convert the `port` to `0`.
However, that test was actually dependent on the following leak from a
test above it:
process.env.HOST = 'localhost';
Switching to `vi.stubEnv` and ensuring to call `vi.unstubAllEnvs`
reveals that the behavior is broken.
This updates the behavior to apply the same check to `_userOptions.port`
as we do to `_userOptions`, and coerce `number` and `string` values to
integers.
pi0
reviewed
Feb 7, 2025
|
|
||
| describe("localhost", () => { | ||
| afterEach(() => { | ||
| vi.unstubAllEnvs(); |
Member
There was a problem hiding this comment.
This seems sonehow breaking tests os.networkInterfaces() becomes undefined
pi0
reviewed
Feb 7, 2025
| typeof _userOptions.port === "number" || | ||
| typeof _userOptions.port === "string" // Shouldn't happen, but just in case | ||
| ) { | ||
| _userOptions.port = Number.parseInt(_userOptions.port + "") || 0; |
Member
There was a problem hiding this comment.
This might be silent ~> random behavior if port is XYZ it will become 0 silently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being passed
{ port: '0' }({ port: string }) is a Typescript type error, but we explicitly have a test that checks that it is gracefully handled, with behavior matching being passed{ port: 0 }({ port: number }),'0'(string), or0(number),which all convert the
portto0.However, that test was actually dependent on the following leak from a test above it:
Switching to
vi.stubEnvand ensuring to callvi.unstubAllEnvsreveals that the behavior is broken.This updates the behavior to apply the same check to
_userOptions.portas we do to_userOptions, and coercenumberandstringvalues to integers.